fix(kit): merge initialValue defaults when syncing client shared state#276
Merged
fix(kit): merge initialValue defaults when syncing client shared state#276
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vitejs/devtools
@vitejs/devtools-kit
@vitejs/devtools-rolldown
@vitejs/devtools-rpc
@vitejs/devtools-self-inspect
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The client-side shared state currently replaces its state entirely with server values (
state.mutate(() => serverState)), without merging the client'sinitialValuedefaults. This means if the server state is missing a newly added field (e.g.commandShortcutsfrom stale persisted data), the client loses it — causing "Cannot set properties of undefined" errors.This fix mirrors the server-side
createStoragemerge strategy ({ ...initialValue, ...savedValue }) on the client side, ensuring new default fields are always preserved when syncing with the server. This prevents the entire class of "new settings field is undefined" bugs.closes #263
Linked Issues
closes #263
Alternative to #264
Additional context
As noted in #264, the proper fix is in the merge layer rather than adding per-field guards in UI components. The merge is applied in all three code paths where server state replaces client state: initial fetch, live update events, and the no-initialValue branch.